Re: [PATCH 2/4] Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile arguments
- From
Jeff King <peff@peff.net>
- Date
- May 28, 2009, 19:35 UTC
- Message-ID
- <20090528193537.GA14324@coredump.intra.peff.net>
- In-Reply-To
- <vVyKoW1VAw2ieNPkJ-SGMNqgFzp_toRpDdk-ZeAp3qzdczSzN4yckg@cipher.nrlssc.navy.mil>
On Thu, May 28, 2009 at 02:32:20PM -0500, Brandon Casey wrote:
Show 9 quoted lines
> >> This library is required on Solaris since hstrerror resides in libresolv. > >> Additionally, on Solaris 7, inet_ntop and inet_pton reside there too. > > > > Patch works for me on Solaris 8, though it is largely a non-issue: > > hstrerror is only used at all if NO_IPV6 is set, and I don't set that > > for my build. > > Ah, in that case I guess NEED_RESOLV should only go in the 5.7 specific > configuration section.
Well, not exactly. Getting rid of NO_HSTRERROR and then compiling with NO_IPV6 still requires NEED_RESOLV. It's just that NO_HSTRERROR isn't even useful unless NO_IPV6 is defined.
-Peff