git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATH

From
Jeff King <peff@peff.net>
Date
May 28, 2009, 19:13 UTC
Message-ID
<20090528191342.GF13499@coredump.intra.peff.net>
In-Reply-To
<8D9Pn2N3FZLQcyxrPABrGxTLa3Dlq25WDqK5xSJyY6cvQv4mphIUXvRu59EA7ewVS-vbi5IZUc4@cipher.nrlssc.navy.mil>
On Wed, May 27, 2009 at 09:17:08PM -0500, Brandon Casey wrote:
Show 9 quoted lines
> Some platforms (like SunOS and family) have kept their common binaries at
> some historical moment in time, and introduced new binaries with modern
> features in a special location like /usr/xpg4/bin or /usr/ucb.  Some of the
> features provided by these modern binaries are expected and required by git.
> If the featureful binaries are not in the users path, then git could end up
> using the less featureful binary and fail.
> 
> So provide a mechanism to prepend elements to the users PATH at runtime so
> the modern binaries will be found.

My concern with this is that the PATH bleeds over into things we execute on behalf of the user, like GIT_EDITOR or snippets in git-filter-branch. So we can end up surprising users that way.

On the other hand, I don't know how big a problem that is in practice. I feel like any sane Solaris user is going to have xpg4 in their PATH these days.

-Peff
Previous: Brandon CaseyNext: Junio C Hamano
Message 5 of 10 in “Makefile: use /usr/ucb/install on SunOS platforms rather than ginstall”
  1. 1/4 Makefile: use /usr/ucb/install on SunOS platforms rather than ginstallBrandon Casey, May 28, 2009
  2. 2/4 Makefile: add NEEDS_RESOLV to optionally add -lresolv to compile argumentsBrandon Casey, May 28, 2009
  3. 3/4 Makefile: add section for SunOS 5.7Brandon Casey, May 28, 2009
  4. 4/4 Makefile: introduce SANE_TOOL_PATH for prepending required elements to PATHBrandon Casey, May 28, 2009
  5. Jeff KingMay 28, 2009
  6. Junio C HamanoMay 29, 2009
  7. Jeff KingMay 28, 2009
  8. Brandon CaseyMay 28, 2009
  9. Jeff KingMay 28, 2009
  10. Jeff KingMay 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.