git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] compat: add a mkstemps() compatibility function

From
David Aguilar <davvid@gmail.com>
Date
May 28, 2009, 09:31 UTC
Message-ID
<20090528093152.GA12566@gmail.com>
In-Reply-To
<4A1E3834.3020502@viscovery.net>
On Thu, May 28, 2009 at 09:07:32AM +0200, Johannes Sixt wrote:
Show 12 quoted lines
> David Aguilar schrieb:
> 
> You should not include "random" system headers, nor has mkstemps any
> business deciding whether files are opened in binary mode. We are not
> using O_BINARY anywhere else (except in compat/mingw.c). With the patch
> below squashed in (I hope it won't be wrapped) you can add:
> 
> Tested-by: Johannes Sixt <j6t@kdbg.org> (Windows)
> 
> to both your patches. And, yes, I like them :-)
> 
> -- Hannes

Thanks. I'll squash these in and resend 1/2 in a moment.

-- 
	David
Previous: Johannes Sixt
Message 7 of 7 in “compat: add a mkstemps() compatibility function”
  1. 1/2 compat: add a mkstemps() compatibility functionDavid Aguilar, May 28, 2009
  2. 2/2 diff: generate prettier filenames when using GIT_EXTERNAL_DIFFDavid Aguilar, May 28, 2009
  3. Jeff KingMay 28, 2009
  4. David AguilarMay 28, 2009
  5. Jeff KingMay 28, 2009
  6. Johannes SixtMay 28, 2009
  7. David AguilarMay 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.