From: David Aguilar <davvid@gmail.com>
Date: Thu, 28 May 2009 09:31:53 GMT
Subject: Re: [PATCH v2 1/2] compat: add a mkstemps() compatibility function
Message-ID: <20090528093152.GA12566@gmail.com>
In-Reply-To: <4A1E3834.3020502@viscovery.net>

On Thu, May 28, 2009 at 09:07:32AM +0200, Johannes Sixt wrote:
> David Aguilar schrieb:
> 
> You should not include "random" system headers, nor has mkstemps any
> business deciding whether files are opened in binary mode. We are not
> using O_BINARY anywhere else (except in compat/mingw.c). With the patch
> below squashed in (I hope it won't be wrapped) you can add:
> 
> Tested-by: Johannes Sixt <j6t@kdbg.org> (Windows)
> 
> to both your patches. And, yes, I like them :-)
> 
> -- Hannes


Thanks.
I'll squash these in and resend 1/2 in a moment.


-- 

	David