Re: [PATCH] 64-bit fix for date.c.

From: Bernd Ahlers <bernd@ba-net.org>
Date: May 4, 2009, 14:26 UTC
Message-ID: <20090504142614.GE8658@jenna.bytemine.net>
In-Reply-To: <20090406190657.GC28120@coredump.intra.peff.net>

Jeff King [Mon, Apr 06, 2009 at 03:06:58PM -0400] wrote:

Show 14 quoted lines

>On Mon, Apr 06, 2009 at 07:26:37PM +0200, Bernd Ahlers wrote:
>
>> @@ -871,13 +871,15 @@ unsigned long approxidate(const char *date)
>>  	struct timeval tv;
>> +	time_t time_sec;
>> [...]
>>  	gettimeofday(&tv, NULL);
>> -	localtime_r(&tv.tv_sec, &tm);
>> +	time_sec = tv.tv_sec;
>> +	localtime_r(&time_sec, &tm);
>
>Hmph. According to POSIX, tv_sec _is_ a time_t. But I see on FreeBSD,
>also, it is actually a "long". So I think this fix makes sense.
>

Okay. So what's the next step to get this committed? :)

Bernd