Re: [PATCH] 64-bit fix for date.c.

From: Jeff King <peff@peff.net>
Date: Apr 6, 2009, 19:06 UTC
Message-ID: <20090406190657.GC28120@coredump.intra.peff.net>
In-Reply-To: <20090406172637.GA17437@jenna.bytemine.net>

On Mon, Apr 06, 2009 at 07:26:37PM +0200, Bernd Ahlers wrote:

Show 8 quoted lines

> @@ -871,13 +871,15 @@ unsigned long approxidate(const char *date)
>  	struct timeval tv;
> +	time_t time_sec;
> [...]
>  	gettimeofday(&tv, NULL);
> -	localtime_r(&tv.tv_sec, &tm);
> +	time_sec = tv.tv_sec;
> +	localtime_r(&time_sec, &tm);

Hmph. According to POSIX, tv_sec _is_ a time_t. But I see on FreeBSD, also, it is actually a "long". So I think this fix makes sense.

-Peff