Re: [PATCH 6/6] Remove bareword filehandles in git-send-email.perl
- From
- Francis Galiegue <fge@one2team.com>
- Date
- May 4, 2009, 06:53 UTC
- Message-ID
- <200905040853.45186.fge@one2team.com>
- In-Reply-To
- <20090504081254.64e289fd@pc09.procura.nl>
Le lundi 04 mai 2009, vous avez écrit : [...]
Show 12 quoted lines
> >
> > And why not go the full way and using IO::File?
>
> Because that would be travelling back in time.
> The most efficient and preferred way is three-arg lexical:
>
> open my $fh, "<", $filename or die "$filename: $!";
> while (<$fh>) {
> # ...
> }
> close $fh or die "$filename: $!";
> I don't see how using IO::File is going back in time at all. It's a standard perl module, even in 5.10.
Show 7 quoted lines
>
> > my $fh = new IO::File;
> >
> > $fh->open("/the/file", O_RDONLY|...)
>
> Why use a module for something that is neatly buit in?
> Because it reads better? YMMV, of course. I prefer using IO::File because perl has too many keywords for its own good :p
-- Francis Galiegue ONE2TEAM Ingénieur système Mob : +33 (0) 683 877 875 Tel : +33 (0) 178 945 552 fge@one2team.com 40 avenue Raymond Poincaré 75116 Paris