[PATCH 5/6] Re: Remove mix of high and low-precedence booleans

From

NSNicolas Sebrecht <nicolas.s.dev@gmail.com>

Date

Apr 29, 2009, 16:54 UTC

Message-ID

<20090429165407.GB12908@vidovic>

In-Reply-To

<1241010743-7020-6-git-send-email-wfp5p@virginia.edu>

On Wed, Apr 29, 2009 at 09:12:22AM -0400, Bill Pemberton wrote:

> Booleans such as &&, ||, ! have higher precedence than and, or, not.
> They should not be mixed.

> -	} elsif (-d $f and !check_file_rev_conflict($f)) {
> +	} elsif (-d $f && !check_file_rev_conflict($f)) {

> -	} elsif ((-f $f or -p $f) and !check_file_rev_conflict($f)) {
> +	} elsif ((-f $f || -p $f) && !check_file_rev_conflict($f)) {

> -		if (!defined $valid_re or $resp =~ /$valid_re/) {
> +		if (!defined $valid_re || $resp =~ /$valid_re/) {

-- 
Nicolas Sebrecht