git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] remote.c: silently tolerate single-level keys like remote.default

From
Jeff King <peff@peff.net>
Date
Apr 23, 2009, 20:01 UTC
Message-ID
<20090423200136.GA3056@coredump.intra.peff.net>
In-Reply-To
<200904232037.27095.j6t@kdbg.org>
On Thu, Apr 23, 2009 at 08:37:26PM +0200, Johannes Sixt wrote:
Show 5 quoted lines
> >   + warn("Config with no key for remote %s", name);
> >   + return 0;
> 
> I don't like this. This would warn in a number of situations where it's not 
> obvious that remotes are involved, for example in 'git status'.

Ah, I didn't think of that (I didn't really look too closely into the affected code, and you obviously have). So let me withdraw my comment.

-Peff
Previous: Johannes SixtNext: Junio C Hamano
Message 5 of 6 in “remote.c: silently tolerate single-level keys like remote.default”
  1. 1/2 remote.c: silently tolerate single-level keys like remote.defaultJohannes Sixt, Apr 23, 2009
  2. 2/2 builtin-help: silently tolerate unknown keysJohannes Sixt, Apr 23, 2009
  3. Jeff KingApr 23, 2009
  4. Johannes SixtApr 23, 2009
  5. Jeff KingApr 23, 2009
  6. Junio C HamanoApr 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.