From: Jeff King Date: Thu, 23 Apr 2009 20:01:37 GMT Subject: Re: [PATCH 1/2] remote.c: silently tolerate single-level keys like remote.default Message-ID: <20090423200136.GA3056@coredump.intra.peff.net> In-Reply-To: <200904232037.27095.j6t@kdbg.org> On Thu, Apr 23, 2009 at 08:37:26PM +0200, Johannes Sixt wrote: > > + warn("Config with no key for remote %s", name); > > + return 0; > > I don't like this. This would warn in a number of situations where it's not > obvious that remotes are involved, for example in 'git status'. Ah, I didn't think of that (I didn't really look too closely into the affected code, and you obviously have). So let me withdraw my comment. -Peff