Re: [BUG?] How to make a shared/restricted repo?

From: Johan Herland <johan@herland.net>
Date: Mar 25, 2009, 02:11 UTC
Message-ID: <200903250311.56300.johan@herland.net>
In-Reply-To: <7vvdpybf9i.fsf@gitster.siamese.dyndns.org>

On Wednesday 25 March 2009, Junio C Hamano wrote:

> You might like to try a patch like this (untested).
>
>  path.c |   17 +++++------------
>  1 files changed, 5 insertions(+), 12 deletions(-)

Thanks!

This works much better :)

However, there are still some questions/issues:

- t1301-shared-repo.sh fails:
    Oops, .git/HEAD is not 0664 but -rw-rw---- [...]
    * FAIL 3: shared=1 does not clear bits preset by umask 022
  (I guess this is expected, as your patch changes the assumptions)

- Loose objects and pack files are still world-readable.

- Shared repos are no longer world-readable by default (requires
  "--shared=all" to be world-readable). This might be
  confusing to old users with lenient umasks, and should probably be
  mentioned in the documentation. AFAICS, it also has nasty effects
  on existing repos with core.sharedRepository == 1. We should probably
  re-roll the patch adding a new keyword (e.g. "group-only"), instead of
  changing the semantics of existing keywords/modes.

- Files/dirs copied from template directory are still world-readable.
  (This is not a big deal at all)

Have fun! :)

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net