git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] documentation: Makefile accounts for SHELL_PATH setting

From
Jeff King <peff@peff.net>
Date
Mar 23, 2009, 06:57 UTC
Message-ID
<20090323065710.GA7048@coredump.intra.peff.net>
In-Reply-To
<1237728044-15651-1-git-send-email-bwalton@artsci.utoronto.ca>
On Sun, Mar 22, 2009 at 09:20:44AM -0400, Ben Walton wrote:
> Ensure that the Makefile that generates and installs the Documentation
> is aware of any SHELL_PATH setting.  Use this value if found or the
> current setting for SHELL if not.  This is an accommodation for systems
> where sh is not bash.
Nit: I have lots of systems where sh is not bash, and they work fine. It
is really about "where sh is not horribly broken". There aren't (AFAIK)
and should not be any bash-isms in these scripts.
The patch itself looks fine; thanks for addressing my concerns.
-Peff
Previous: Ben WaltonNext: Ben Walton
Message 2 of 10 in “documentation: Makefile accounts for SHELL_PATH setting”
  1. documentation: Makefile accounts for SHELL_PATH settingBen Walton, Mar 22, 2009
  2. Jeff KingMar 23, 2009
  3. Ben WaltonMar 23, 2009
  4. Jeff KingMar 23, 2009
  5. Mike HommeyMar 23, 2009
  6. Nanako ShiraishiApr 10, 2009
  7. Junio C HamanoApr 11, 2009
  8. Ben WaltonApr 12, 2009
  9. Junio C HamanoApr 12, 2009
  10. Ben WaltonApr 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.