From: Jeff King <peff@peff.net>
Date: Mon, 23 Mar 2009 06:57:10 GMT
Subject: Re: [PATCH] documentation: Makefile accounts for SHELL_PATH setting
Message-ID: <20090323065710.GA7048@coredump.intra.peff.net>
In-Reply-To: <1237728044-15651-1-git-send-email-bwalton@artsci.utoronto.ca>

On Sun, Mar 22, 2009 at 09:20:44AM -0400, Ben Walton wrote:

> Ensure that the Makefile that generates and installs the Documentation
> is aware of any SHELL_PATH setting.  Use this value if found or the
> current setting for SHELL if not.  This is an accommodation for systems
> where sh is not bash.

Nit: I have lots of systems where sh is not bash, and they work fine. It
is really about "where sh is not horribly broken". There aren't (AFAIK)
and should not be any bash-isms in these scripts.

The patch itself looks fine; thanks for addressing my concerns.

-Peff