git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] removed some unused variables

From
Jeff King <peff@peff.net>
Date
Mar 7, 2009, 23:52 UTC
Message-ID
<20090307235245.GA19926@coredump.intra.peff.net>
In-Reply-To
<7f978c810903071202w59a5ca37id6d1fee405c24e9c@mail.gmail.com>
On Sat, Mar 07, 2009 at 09:02:10PM +0100, Benjamin Kramer wrote:
> these variables were unused and can be removed safely
> 
> builtin-clone: removed unused variable 'option_no_hardlinks'

I did a double-take here, as I was just looking at option_no_hardlinks code the other day. But looking at your patch, I think you meant "use_local_hardlinks".

> @@ -388,9 +386,6 @@ int cmd_clone(int argc, const char **argv, const
> char *prefix)

Your patch is damaged due to wrapping here (and several other places). Please check your mailer settings.

Other than that, I think it is a fine cleanup.
-Peff
Previous: Benjamin Kramer
Message 2 of 2 in “removed some unused variables”
  1. 1/2 removed some unused variablesBenjamin Kramer, Mar 7, 2009
  2. Jeff KingMar 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.