From: Jeff King Date: Sat, 07 Mar 2009 23:52:46 GMT Subject: Re: [PATCH 1/2] removed some unused variables Message-ID: <20090307235245.GA19926@coredump.intra.peff.net> In-Reply-To: <7f978c810903071202w59a5ca37id6d1fee405c24e9c@mail.gmail.com> On Sat, Mar 07, 2009 at 09:02:10PM +0100, Benjamin Kramer wrote: > these variables were unused and can be removed safely > > builtin-clone: removed unused variable 'option_no_hardlinks' I did a double-take here, as I was just looking at option_no_hardlinks code the other day. But looking at your patch, I think you meant "use_local_hardlinks". > @@ -388,9 +386,6 @@ int cmd_clone(int argc, const char **argv, const > char *prefix) Your patch is damaged due to wrapping here (and several other places). Please check your mailer settings. Other than that, I think it is a fine cleanup. -Peff