Re: [RFC/PATCH 1/2] improve missing repository error message
- From
Jeff King <peff@peff.net>
- Date
- Mar 5, 2009, 10:36 UTC
- Message-ID
- <20090305103659.GA17196@coredump.intra.peff.net>
- In-Reply-To
- <20090304185742.GI14365@spearce.org>
On Wed, Mar 04, 2009 at 10:57:42AM -0800, Shawn O. Pearce wrote:
Show 8 quoted lines
> > > IMHO, maybe we also should change the error message that receive-pack > > > produces when the path its given isn't a Git repository. Its really > > > not very human friendly to say "unable to chdir or not a git archive". > > > Hell, we don't even call them archives, we call them repositories. > > I really mean to write this patch myself, I haven't done much for > git lately. But I got sidetracked yesterday and forgot. Thank you > for doing it for me.
I think you are OK coasting on past glory for a while longer:
$ git shortlog -ns | egrep -im2 'jeff|shawn' 1313 Shawn O. Pearce 305 Jeff King
:)
> > Perhaps this should match the local "Not a git repository: %s". I prefer > > this text, but maybe there is value in consistency. > > FWIW I also prefer the text you used in the patch...
I don't know if it is worth changing the _local_ one to match this, then. I seem to recall some discussion about that message recently. Personally I find the "Not a git repository (or any of the parent directories)" wording to be quite awkward.
-Peff