Re: [PATCH] git-svn: try to read the dcommit url from the config file

From: Eric Wong <normalperson@yhbt.net>
Date: Feb 23, 2009, 02:05 UTC
Message-ID: <20090223020545.GE26706@dcvr.yhbt.net>
In-Reply-To: <200902222241.56223.kumbayo84@arcor.de>

Peter Oberndorfer <kumbayo84@arcor.de> wrote:

Show 14 quoted lines

> On Samstag 21 Februar 2009, Eric Wong wrote:
> > Peter Oberndorfer <kumbayo84@arcor.de> wrote:
> > > The commit url is determined in the following order
> > > --commit-url commandline
> > 
> > actually, it should look in the .git/config for this, too:
> > 
> >   svn.commiturl
> > 
> 
> I did not see that the commandline options are also searched in the
> config.  Also this option does not seem to be documented.  Should i
> document svn.commiturl in dcommit or is that just a implementation
> detail.

Please document svn.commiturl, thanks

Show 10 quoted lines

> > > svn-remote.<name>.dcommiturl
> > 
> > Of course, having a per-svn-remote commiturl can be useful, too.
> > 
> > Though I'd call it "commiturl" instead of "dcommiturl" to match the
> > existing config setting.  The not-often-used "set-tree" command could
> > probably be updated to use these config options, too...
> > 
> 
> sorry, i do not understand enough of perl/git-svn to do this :-(

Don't worry about set-tree, for now :) dcommit has been the recommended workflow for a while now so very few people use set-tree (it's highly git-centric and makes history confusing to SVN users).

> > I'll ack this patch with "dcommiturl" replaced with "commiturl".
> > 
> 
> OK, will resend the patch once i know if i should document svn.commiturl.

Thanks Peter

-- 
Eric Wong