Re: [PATCH] git-svn: try to read the dcommit url from the config file
- From
Peter Oberndorfer <kumbayo84@arcor.de>
- Date
- Feb 22, 2009, 21:41 UTC
- Message-ID
- <200902222241.56223.kumbayo84@arcor.de>
- In-Reply-To
- <20090221120815.GA8145@dcvr.yhbt.net>
On Samstag 21 Februar 2009, Eric Wong wrote:
Show 8 quoted lines
> Peter Oberndorfer <kumbayo84@arcor.de> wrote: > > The commit url is determined in the following order > > --commit-url commandline > > actually, it should look in the .git/config for this, too: > > svn.commiturl >
I did not see that the commandline options are also searched in the config. Also this option does not seem to be documented. Should i document svn.commiturl in dcommit or is that just a implementation detail.
Show 8 quoted lines
> > svn-remote.<name>.dcommiturl > > Of course, having a per-svn-remote commiturl can be useful, too. > > Though I'd call it "commiturl" instead of "dcommiturl" to match the > existing config setting. The not-often-used "set-tree" command could > probably be updated to use these config options, too... >
sorry, i do not understand enough of perl/git-svn to do this :-(
> I'll ack this patch with "dcommiturl" replaced with "commiturl". >
OK, will resend the patch once i know if i should document svn.commiturl.
Show 5 quoted lines
> > svn-remote.<name>.url > > > > Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de> > > --- > >
Greetings Peter