autocrlf=input and safecrlf (was Re: CVS import [SOLVED])

From: Jeff King <peff@peff.net>
Date: Feb 20, 2009, 17:29 UTC
Message-ID: <20090220172918.GB4636@coredump.intra.peff.net>
In-Reply-To: <32886.77.61.241.211.1235147143.squirrel@hupie.xs4all.nl>

On Fri, Feb 20, 2009 at 05:25:43PM +0100, Ferry Huberts (Pelagic) wrote:

Show 5 quoted lines

> I replied in the thread with something comparable:
> http://article.gmane.org/gmane.comp.version-control.git/110358
> 
> My suggestion is make sure that safecrlf is set to false (see the end
> part of the mail)

Oh, sorry, I missed that bit. You said:

Show 5 quoted lines

> Back to the issue:
> I think requiring autocrlf = false is too strict.  Requiring autocrlf
> = false should be enough. That combined with a bit of text in the
> manual page about these settings: autocrlf = false is strongly
> recommended. Also, safecrlf is required to be set to false.

Assuming there is a typo and you meant to say "Requiring safecrlf = false should be enough", then yes, I agree. But if you are recommending to put that into the "git cvsimport" manpage, I'm not sure that makes sense. Setting autocrlf to input and turning on safecrlf breaks much more than that; you can't add any file that has a CRLF in it. So such a warning should probably go in the config description for those options.

I still think safecrlf could probably be made more useful in this case to differentiate between "this will corrupt your data if you do a checkout with your current config settings" and "this will corrupt your data forever". But I am not a user of either config variable, so maybe there is some subtlety I'm missing.

-Peff