Re: autocrlf=input and safecrlf (was Re: CVS import [SOLVED])

From: Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
Date: Feb 23, 2009, 07:09 UTC
Message-ID: <1570.77.61.241.211.1235372943.squirrel@hupie.xs4all.nl>
In-Reply-To: <20090223065615.GA24807@coredump.intra.peff.net>

On Mon, February 23, 2009 07:56, Jeff King wrote:

Show 20 quoted lines

> [Can you please wrap your lines? They seem to be about 200 characters,
>  and then rewrap the quoted text, but without putting a '>' marker.
>  I had a very hard time figuring out what was quoted and what was not.]
>
> On Mon, Feb 23, 2009 at 07:50:48AM +0100, Ferry Huberts (Pelagic) wrote:
>
>> > I am a bit concerned about a proposal to set safecrlf=false in all
>> > cvsimported repositories.  You are turning off the protection
>> > against corrupting binary files.  _Even if_ the person has put
>> > safecrlf=true into their ~/.gitconfig and thinks they are safe.
>>
>> Ok.  I follow and agree. Full circle :-) We're back to Johannes'
>> proposal: make sure that autocrlf is set to false. Agree? If so, then
>> I'll try to whip up a patch.
>
> But won't that now import CRLF's into your new git repo? Especially on
> Windows, where (IIRC) cvs gives you files with CRLF by default?
>
> -Peff
>

Yes it would. But sadly that's the only way to make sure that the import will work (without serious manual intervention). I found this out the hard way.

I started these discussions to narrow down on what we should actually patch. Now it appears that we should do what Johannes originally proposed. Always nice to be right, isn't it Johannes? :-)

Ferry