git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [topgit] tg update error

From
Jeff King <peff@peff.net>
Date
Feb 14, 2009, 02:08 UTC
Message-ID
<20090214020848.GA9907@coredump.intra.peff.net>
In-Reply-To
<7vy6w93hdb.fsf@gitster.siamese.dyndns.org>
On Fri, Feb 13, 2009 at 06:02:56PM -0800, Junio C Hamano wrote:
Show 10 quoted lines
> > As it turns out, topgit is using refs/top-bases/ in HEAD,
> > leading us to re-loosen (at least temporarily) the
> > validate_headref check made in b229d18a. This patch does the
> > corresponding loosening for the symbolic-ref safety valve,
> > so that the two are in agreement once more.
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> 
> Actually we should simply revert afe5d3d5 altogether with the above
> message, as it introduced a test that expects the tightened behaviour.

Is there any reason to throw away the "must be in refs/" safety valve, though? That was the actual patch I started with and solved my problem, and the "tighten to refs/heads/" bit came from discussion. That is, I think having a safety valve in symbolic-ref that matches validate_headref is orthogonal to how tightly validate_headref matches.

But yes, I obviously failed to run the test suite on the follow-up patch I sent. The final test in t1401 would need to be reverted, as well.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 18 of 20 in “[topgit] tg update error”
  1. Aneesh KumarFeb 12, 2009
  2. martin f krafftFeb 12, 2009
  3. Aneesh Kumar K.VFeb 12, 2009
  4. martin f krafftFeb 12, 2009
  5. Aneesh Kumar K.VFeb 12, 2009
  6. Bert WesargFeb 12, 2009
  7. Jeff KingFeb 12, 2009
  8. Jeff KingFeb 12, 2009
  9. martin f krafftFeb 12, 2009
  10. Junio C HamanoFeb 12, 2009
  11. martin f krafftFeb 12, 2009
  12. Junio C HamanoFeb 12, 2009
  13. martin f krafftFeb 13, 2009
  14. Junio C HamanoFeb 13, 2009
  15. Junio C HamanoFeb 13, 2009
  16. Jeff KingFeb 13, 2009
  17. Junio C HamanoFeb 14, 2009
  18. Jeff KingFeb 14, 2009
  19. Junio C HamanoFeb 14, 2009
  20. Jeff KingFeb 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.