git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] builtin-remote: teach show to display remote HEAD

From
Jeff King <peff@peff.net>
Date
Feb 12, 2009, 01:56 UTC
Message-ID
<20090212015559.GB3187@sigill.intra.peff.net>
In-Reply-To
<76718490902111748j58f80591ma149f8ec9fb8b352@mail.gmail.com>
On Wed, Feb 11, 2009 at 08:48:42PM -0500, Jay Soffian wrote:
> Damn, I knew I wasn't going to slip that one by. :-)
"Given enough eyeballs, all ugly hacks are shallow." :)
Show 9 quoted lines
> > I see that the inputs and outputs aren't exactly the same in both cases,
> 
> Which is why I didn't refactor it. The extra code needed to massage
> what builtin-remote.c has to the existing function in builtin-clone.c
> would've been more LOC than the duplicate code (I think...).
> 
> BUT
> 
> I'll try. :-)

See what you can do. But personally, I am not as concerned with reducing LOC as I am with encapsulating system logic like "this is how you guess which ref is HEAD". And if you can do both, great. :)

-Peff
Previous: Jay SoffianNext: Daniel Barkalow
Message 7 of 17 in “remote HEAD improvements”
  1. 0/3 remote HEAD improvementsJay Soffian, Feb 11, 2009
  2. 1/3 builtin-remote: move duplicated cleanup code its own functionJay Soffian, Feb 11, 2009
  3. 2/3 builtin-remote: teach show to display remote HEADJay Soffian, Feb 11, 2009
  4. 3/3 builtin-remote: add sethead verbJay Soffian, Feb 11, 2009
  5. Jeff KingFeb 12, 2009
  6. Jay SoffianFeb 12, 2009
  7. Jeff KingFeb 12, 2009
  8. Daniel BarkalowFeb 12, 2009
  9. Junio C HamanoFeb 12, 2009
  10. Daniel BarkalowFeb 12, 2009
  11. Jay SoffianFeb 12, 2009
  12. Daniel BarkalowFeb 12, 2009
  13. Jeff KingFeb 12, 2009
  14. Jay SoffianFeb 12, 2009
  15. Jeff KingFeb 12, 2009
  16. Daniel BarkalowFeb 12, 2009
  17. Jeff KingFeb 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.