From: Jeff King <peff@peff.net>
Date: Thu, 12 Feb 2009 01:56:00 GMT
Subject: Re: [PATCH 2/3] builtin-remote: teach show to display remote HEAD
Message-ID: <20090212015559.GB3187@sigill.intra.peff.net>
In-Reply-To: <76718490902111748j58f80591ma149f8ec9fb8b352@mail.gmail.com>

On Wed, Feb 11, 2009 at 08:48:42PM -0500, Jay Soffian wrote:

> Damn, I knew I wasn't going to slip that one by. :-)

"Given enough eyeballs, all ugly hacks are shallow." :)

> > I see that the inputs and outputs aren't exactly the same in both cases,
> 
> Which is why I didn't refactor it. The extra code needed to massage
> what builtin-remote.c has to the existing function in builtin-clone.c
> would've been more LOC than the duplicate code (I think...).
> 
> BUT
> 
> I'll try. :-)

See what you can do. But personally, I am not as concerned with reducing
LOC as I am with encapsulating system logic like "this is how you guess
which ref is HEAD". And if you can do both, great. :)

-Peff