git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH JGIT] In the commit dialog, deal with Signed-off-by not on the last line (WAS: [PATCH JGIT] Deal with the signed-off in the commit text dialog)

From
Shawn O. Pearce <spearce@spearce.org>
Date
Feb 11, 2009, 19:40 UTC
Message-ID
<20090211194058.GV30949@spearce.org>
In-Reply-To
<499304A2.1060908@gmail.com>
Yann Simon <yann.simon.fr@gmail.com> wrote:
> 
> This patch should correct this assumption.
Maybe, but it can't be applied...
 
Show 5 quoted lines
> +                    String neuSignOff = getSignedOff(neuCommitter);
> +                   
> commitText.setText(replaceSignOff(commitText.getText(), oldSignOff,
> neuSignOff));
> +                    oldCommitter = neuCommitter;
That's whitespace corruption.
-- 
Shawn.
Previous: Yann Simon
Message 4 of 4 in “Deal with the signed-off in the commit text dialog”
  1. Deal with the signed-off in the commit text dialogYann Simon, Feb 10, 2009
  2. Robin RosenbergFeb 11, 2009
  3. In the commit dialog, deal with Signed-off-by not on the last line (WAS: [PATCH JGIT] Deal with the signed-off in the commit text dialog)Yann Simon, Feb 11, 2009
  4. Shawn O. PearceFeb 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.