git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH JGIT] Deal with the signed-off in the commit text dialog

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Feb 11, 2009, 00:16 UTC
Message-ID
<200902110116.36172.robin.rosenberg.lists@dewire.com>
In-Reply-To
<49917944.6030309@gmail.com>
tisdag 10 februari 2009 13:55:32 skrev Yann Simon:
Show 7 quoted lines
> The user can see and edit the signed-off in the commit dialog
> before committing.
> 
> Updating the committer updates the signed-off.
> 
> For new lines in the commit dialog, use Text.DELIMITER for
> plateform neutrality.
Spell "platform"

These is two unrelated changes. I don't deeply about the switch, but I do want the line end handling so we don't get double spaced messages.

The toggle swithch will happily double the SOB-line. It assumes it is the last line. Isn't that too strict, though it is the common idiom, but we also have other types of X-by-lines that we often place below the SOB line.

Signed-off-by: hacker
Signed-off-by: pschorff
Acked-by: bar
-- robin
Previous: Yann SimonNext: Yann Simon
Message 2 of 4 in “Deal with the signed-off in the commit text dialog”
  1. Deal with the signed-off in the commit text dialogYann Simon, Feb 10, 2009
  2. Robin RosenbergFeb 11, 2009
  3. In the commit dialog, deal with Signed-off-by not on the last line (WAS: [PATCH JGIT] Deal with the signed-off in the commit text dialog)Yann Simon, Feb 11, 2009
  4. Shawn O. PearceFeb 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.