git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make repack less likely to corrupt repository

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Feb 11, 2009, 00:27 UTC
Message-ID
<200902110127.18149.robin.rosenberg.lists@dewire.com>
In-Reply-To
<7vd4dpkfr2.fsf@gitster.siamese.dyndns.org>
onsdag 11 februari 2009 00:56:49 skrev Junio C Hamano:
> We failed to honor what the end user wanted: to repack.  Why should we
> exit 0 here?

A repack may or may not yield a better packed repo. In this case, not, but for a different reason than failing to find better deltas. Given the circumstances that is most likely to cause the "failure (repacking on windows), this is "normal" behaviour and no reason to scare the user with an error code. The unlink error might be enough. I think scripts should be able to continue too. The alternative would be to have a switch to repack that scripts and UI's could enable, like -q for "don't flag malign errors", or the other way, a --pedantic for "flag failure to make object database smaller".

-- robin
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 20 in “Make repack less likely to corrupt repository”
  1. Make repack less likely to corrupt repositoryRobin Rosenberg, Feb 9, 2009
  2. Junio C HamanoFeb 9, 2009
  3. Robin RosenbergFeb 10, 2009
  4. Junio C HamanoFeb 10, 2009
  5. Robin RosenbergFeb 10, 2009
  6. Junio C HamanoFeb 10, 2009
  7. Robin RosenbergFeb 10, 2009
  8. Junio C HamanoFeb 10, 2009
  9. Robin RosenbergFeb 11, 2009
  10. Junio C HamanoFeb 11, 2009
  11. Robin RosenbergFeb 11, 2009
  12. Robin RosenbergFeb 15, 2009
  13. Johannes SchindelinFeb 15, 2009
  14. Robin RosenbergFeb 15, 2009
  15. Junio C HamanoFeb 15, 2009
  16. Robin RosenbergFeb 16, 2009
  17. Robin RosenbergFeb 19, 2009
  18. Johannes SchindelinFeb 19, 2009
  19. Junio C HamanoFeb 20, 2009
  20. Junio C HamanoFeb 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.