Re: [PATCH v4 3/4] add -p: prompt for single characters

From: Jeff King <peff@peff.net>
Date: Feb 6, 2009, 14:01 UTC
Message-ID: <20090206140126.GA18364@coredump.intra.peff.net>
In-Reply-To: <1233822507-9612-1-git-send-email-trast@student.ethz.ch>

On Thu, Feb 05, 2009 at 09:28:26AM +0100, Thomas Rast wrote:

Show 7 quoted lines

> +my $use_readkey = 0;
> +if ($repo->config_bool("interactive.singlekey")) {
> +	eval {
> +		use Term::ReadKey;
> +		$use_readkey = 1;
> +	};
> +}

Sorry, I am way behind on git mails, so I didn't catch this sooner. But it should be "require Term::ReadKey", as "use" statements are done at compile time:

  $ perl -e 'eval { use Bogosity } or print "not found\n"'
  Can't locate Bogosity.pm in @INC ...

  $ perl -e 'eval { require Bogosity } or print "not found\n"'
  not found

So add--interactive in 'next' is currently broken on non-readkey platforms.

-Peff