git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] apply: fix access to an uninitialized mode variable, found by valgrind

From
Jeff King <peff@peff.net>
Date
Feb 4, 2009, 15:31 UTC
Message-ID
<20090204153150.GC6896@sigill.intra.peff.net>
In-Reply-To
<alpine.DEB.1.00.0902040249030.9822@pacific.mpi-cbg.de>
On Wed, Feb 04, 2009 at 02:50:15AM +0100, Johannes Schindelin wrote:
> When 'tpatch' was initialized successfully, st_mode was already taken
> from the previous diff.  We should not try to override it with data
> from an lstat() that was never called.
Yay. Valgrind For The Win, as the kids are saying these days.

Was this being triggered by t4121 and t4127? If so, then I think it solves the mystery valgrind errors I reported in the last paragraph here:

  http://article.gmane.org/gmane.comp.version-control.git/98898
-Peff
Previous: Don ZickusNext: Johannes Schindelin
Message 4 of 5 in “apply: fix access to an uninitialized mode variable, found by valgrind”
  1. apply: fix access to an uninitialized mode variable, found by valgrindJohannes Schindelin, Feb 4, 2009
  2. Junio C HamanoFeb 4, 2009
  3. Don ZickusFeb 4, 2009
  4. Jeff KingFeb 4, 2009
  5. Johannes SchindelinFeb 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.