From: Jeff King <peff@peff.net>
Date: Wed, 04 Feb 2009 15:31:50 GMT
Subject: Re: [PATCH] apply: fix access to an uninitialized mode variable, found by valgrind
Message-ID: <20090204153150.GC6896@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0902040249030.9822@pacific.mpi-cbg.de>

On Wed, Feb 04, 2009 at 02:50:15AM +0100, Johannes Schindelin wrote:

> When 'tpatch' was initialized successfully, st_mode was already taken
> from the previous diff.  We should not try to override it with data
> from an lstat() that was never called.

Yay. Valgrind For The Win, as the kids are saying these days.

Was this being triggered by t4121 and t4127? If so, then I think it
solves the mystery valgrind errors I reported in the last paragraph
here:

  http://article.gmane.org/gmane.comp.version-control.git/98898

-Peff