git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI

From
Mike Hommey <mh@glandium.org>
Date
Feb 3, 2009, 06:54 UTC
Message-ID
<20090203065457.GA8466@glandium.org>
In-Reply-To
<7v8woodnmj.fsf@gitster.siamese.dyndns.org>
On Mon, Feb 02, 2009 at 10:45:56PM -0800, Junio C Hamano wrote:
Show 10 quoted lines
> Otherwise -Wunused-function (which is implied by -Wall) triggers.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
> I think this patch is probably a bit on the wrong side of the borderline,
> in that it *happens to be* that get_remote_object_url() is used by nobody
> in non-multi codepath right now, but it is entirely possible that future
> code clean-up can benefit from its use.  But without this patch,, the file
> does not compile for me (I compile everything with "-Werror -Wall").

If I recall correctly, http-push just doesn't work without curl-multi, so the correct fix would be to just disable http-push when USE_CURL_MULTI is undefined.

Mike
Previous: Junio C HamanoNext: Tay Ray Chuan
Message 2 of 3 in “http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI”
  1. http-push.c: get_remote_object_url() is only used under USE_CURL_MULTIJunio C Hamano, Feb 3, 2009
  2. Mike HommeyFeb 3, 2009
  3. Tay Ray ChuanFeb 3, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.