From: Mike Hommey <mh@glandium.org>
Date: Tue, 03 Feb 2009 06:54:57 GMT
Subject: Re: [PATCH] http-push.c: get_remote_object_url() is only used under USE_CURL_MULTI
Message-ID: <20090203065457.GA8466@glandium.org>
In-Reply-To: <7v8woodnmj.fsf@gitster.siamese.dyndns.org>

On Mon, Feb 02, 2009 at 10:45:56PM -0800, Junio C Hamano wrote:
> Otherwise -Wunused-function (which is implied by -Wall) triggers.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
> I think this patch is probably a bit on the wrong side of the borderline,
> in that it *happens to be* that get_remote_object_url() is used by nobody
> in non-multi codepath right now, but it is entirely possible that future
> code clean-up can benefit from its use.  But without this patch,, the file
> does not compile for me (I compile everything with "-Werror -Wall").

If I recall correctly, http-push just doesn't work without curl-multi,
so the correct fix would be to just disable http-push when
USE_CURL_MULTI is undefined.

Mike