Re: [PATCH] gitweb: ensure the default stylesheet is accessible

From: Jakub Narebski <jnareb@gmail.com>
Date: Jan 26, 2009, 01:48 UTC
Message-ID: <200901260248.22120.jnareb@gmail.com>
In-Reply-To: <1232933322-9186-1-git-send-email-giuseppe.bilotta@gmail.com>

On Mon, 26 Jan 2009, Giuseppe Bilotta wrote:

> On some installations the CSS fails to be linked correctly when
> path_info is enabled, since the link refers to "gitweb.css", whereas it
> should be "${my_uri}/gitweb.css". Fix by setting the appropriate default
> in the Makefile.

Why "on some installations"? What does "some" mean? I don't think it is something indeterministic: please spell when one can have problems with linking CSS file.

Wouldn't it be simpler to deal with problem of base URL when using path_info gitweb URLs to add BASE element to HTML head if we use path_info? Something like:

	if ($ENV{'PATH_INFO'}) {  # $path_info is unfortunately stripped
		print qq(<base href="$my_uri">\n);
	}

somewhere in git_header_html() subroutine?

See also comment below.

Show 18 quoted lines

> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 4ef8234..4f60de9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -215,7 +215,7 @@ GITWEB_STRICT_EXPORT =
>  GITWEB_BASE_URL =
>  GITWEB_LIST =
>  GITWEB_HOMETEXT = indextext.html
> -GITWEB_CSS = gitweb.css
> +GITWEB_CSS = $${my_uri}/gitweb.css
>  GITWEB_LOGO = git-logo.png
>  GITWEB_FAVICON = git-favicon.png

It is not the same case for git-logo.png and git-favicon.png as for gitweb.css? If it is not, please explain why in commit message. If it is, then your patch is only partial solution to path_info problem.

Show 5 quoted lines

>  GITWEB_SITE_HEADER =
> -- 
> 1.5.6.5
> 
>

-- 
Jakub Narebski
Poland