git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Rename detection: Avoid repeated filespec population

From
Jeff King <peff@peff.net>
Date
Jan 21, 2009, 13:32 UTC
Message-ID
<20090121133211.GA20360@coredump.intra.peff.net>
In-Reply-To
<20090121125619.GA523@atjola.homenet>
On Wed, Jan 21, 2009 at 01:56:19PM +0100, Björn Steinbrink wrote:
> Another possible solution would be to free the blob data only after the
> loop in diffcore_rename has finished, but that's obviously quite bad WRT
> memory consumption.  :-)

Yeah, and it doesn't have the (admittedly smaller, but still there) optimization of not loading the blob data at all if we will never need to.

> Anyway, too late, yesterday's attempts 6 to 10 at writing a better
> commit message didn't work out either, and Junio has applied the patch
> by now.

I think that's fine. My message was more about convincing myself that your change was the right thing (and hopefully helped convince others, too).

-Peff
Previous: Björn SteinbrinkNext: Junio C Hamano
Message 5 of 6 in “Rename detection: Avoid repeated filespec population”
  1. Rename detection: Avoid repeated filespec populationBjörn Steinbrink, Jan 20, 2009
  2. Jeff KingJan 20, 2009
  3. Jeff KingJan 20, 2009
  4. Björn SteinbrinkJan 21, 2009
  5. Jeff KingJan 21, 2009
  6. Junio C HamanoJan 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.