git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Rename detection: Avoid repeated filespec population

From
Björn Steinbrink <b.steinbrink@gmx.de>
Date
Jan 21, 2009, 12:56 UTC
Message-ID
<20090121125619.GA523@atjola.homenet>
In-Reply-To
<20090120212723.GA10967@coredump.intra.peff.net>
On 2009.01.20 16:27:23 -0500, Jeff King wrote:
Show 5 quoted lines
> So I think your patch is absolutely the right thing to do. But I think
> from the commit message it isn't clear that it would not be equally
> correct to follow through on generating cnt_data instead of an early
> return (which _isn't_ right, because you might not need to generate
> cnt_data at all).

Yeah, the commit message wasn't exactly great, but after the fifth attempt I decided to just sent the damn thing, to see whether at least the patch itself makes sense.

Another possible solution would be to free the blob data only after the loop in diffcore_rename has finished, but that's obviously quite bad WRT memory consumption. :-)

Anyway, too late, yesterday's attempts 6 to 10 at writing a better commit message didn't work out either, and Junio has applied the patch by now.

Björn
Previous: Jeff KingNext: Jeff King
Message 4 of 6 in “Rename detection: Avoid repeated filespec population”
  1. Rename detection: Avoid repeated filespec populationBjörn Steinbrink, Jan 20, 2009
  2. Jeff KingJan 20, 2009
  3. Jeff KingJan 20, 2009
  4. Björn SteinbrinkJan 21, 2009
  5. Jeff KingJan 21, 2009
  6. Junio C HamanoJan 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.