Re: [PATCH 3/7 v2] git_extract_argv0_path(): Move check for valid argv0 from caller to callee

From: Johannes Sixt <j6t@kdbg.org>
Date: Jan 18, 2009, 19:28 UTC
Message-ID: <200901182028.11345.j6t@kdbg.org>
In-Reply-To: <200901182016.56395.j6t@kdbg.org>

On Sonntag, 18. Januar 2009, Johannes Sixt wrote:

Show 15 quoted lines

> On Sonntag, 18. Januar 2009, Steffen Prohaska wrote:
> > This simplifies the calling code.
>
> But it could really be squashed into the previous patch, after fixing...
>
> > @@ -23,6 +23,9 @@ const char *system_path(const char *path)
> >
> >  const char *git_extract_argv0_path(const char *argv0)
> >  {
> > +	if (!argv0 || !*argv0)
> > +		return 0;
> > +
> >  	const char *slash = argv0 + strlen(argv0);
>
> ... this declaration after statement.

And we prefer NULL over 0 for the null pointer.

The series is nicely done, thank you! I am using it (the previous round) without problems so far. I hope we can get this in RSN.

-- Hannes