git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] git-am: Make it easier to see which patch failed

From
Jeff King <peff@peff.net>
Date
Jan 18, 2009, 17:07 UTC
Message-ID
<20090118170711.GA17055@coredump.intra.peff.net>
In-Reply-To
<alpine.DEB.1.00.0901181711090.3586@pacific.mpi-cbg.de>
On Sun, Jan 18, 2009 at 05:17:43PM +0100, Johannes Schindelin wrote:
Show 7 quoted lines
> > Yes, I'm surprised Junio doesn't remember the mass conversions we 
> > already had to do (4b7cc26a and 293623ed). But looking at the date, I 
> > guess it _has_ been a year and a half. :)
> 
> Hey, be nice to Junio.  Have you seen the amount of mails on this list 
> recently?  I think Junio's the only one really reading all of them; even 
> if you were right, he would be entitled to a nicer reminder.

I didn't mean to be mean. On the contrary, I was surprised because _he_ usually is the one reminding _me_ about such fixes. I guess Junio is human, after all. :)

> But you are wrong.  And Stephan is wrong, too.
> 
> The name "FIRSTLINE" suggests that it is indeed a first line, and 
> consequently cannot contain a newline.

It is not "this is a problem because it might contain a newline" but "this is a problem because it might contain an escape sequence, _an example_ of which is a \n newline." So the question is whether you can guarantee that $FIRSTLINE does not contain a backslash. Which I don't think is the case here.

-Peff
Previous: Stephan BeyerNext: Johannes Schindelin
Message 12 of 15 in “git-am: Make it easier to see which patch failed”
  1. git-am: Make it easier to see which patch failedJonas Flodén, Jan 16, 2009
  2. Johannes SchindelinJan 16, 2009
  3. git-am: Make it easier to see which patch failedJonas Flodén, Jan 16, 2009
  4. Johannes SchindelinJan 16, 2009
  5. Junio C HamanoJan 18, 2009
  6. Stephan BeyerJan 18, 2009
  7. Stephan BeyerJan 18, 2009
  8. Jeff KingJan 18, 2009
  9. Johannes SchindelinJan 18, 2009
  10. Thomas RastJan 18, 2009
  11. Stephan BeyerJan 18, 2009
  12. Jeff KingJan 18, 2009
  13. Johannes SchindelinJan 18, 2009
  14. Jeff KingJan 18, 2009
  15. Junio C HamanoJan 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.