Re: [PATCH/RFC] git-am: Make it easier to see which patch failed

From: Jeff King <peff@peff.net>
Date: Jan 18, 2009, 15:39 UTC
Message-ID: <20090118153928.GA16664@coredump.intra.peff.net>
In-Reply-To: <20090118094113.GE11992@leksak.fem-net>

On Sun, Jan 18, 2009 at 10:41:13AM +0100, Stephan Beyer wrote:

Show 9 quoted lines

> > Looks sane except that I do not think you need printf nor the leading
> > blank line, i.e.
> > 
> > 	echo "Patch failed at $msgnum ($FIRSTLINE)"
> 
> Hmm, IIRC if $FIRSTLINE contains \n or something like that, it will
> interpret this as newline in some shell/echo implementations.
> 
> So printf "...%s..." "$FOO" is always sane for user input.

Yes, I'm surprised Junio doesn't remember the mass conversions we already had to do (4b7cc26a and 293623ed). But looking at the date, I guess it _has_ been a year and a half. :)

-Peff