git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u."

From
Markus Heidelberg <markus.heidelberg@web.de>
Date
Jan 15, 2009, 22:56 UTC
Message-ID
<200901152356.00997.markus.heidelberg@web.de>
In-Reply-To
<20090113201024.GA20129@chistera.yi.org>
Adeodato Simó, 13.01.2009:
Show 10 quoted lines
> * Boyd Stephen Smith Jr. [Tue, 13 Jan 2009 14:03:11 -0600]:
> 
> > On Tuesday 2009 January 13 10:45:18 Shawn O. Pearce wrote:
> > >See [...] how the subject is a niceshort, one
> > >line summary of the module impacted and the change?
> 
> > My rule for this is absolutely no more than 80 characters.
> 
> My rule for *all* of the commit message is "absolutely no more than 76
> characters". With more than 76, `git log` wraps in a 80-column terminal.

What about the 50 character limit proposed in the documentation (git-commit, gittutorial, user-manual)?

At the beginning I tried to fulfil this limit, but often it's not easy. So should it be adjusted to a slightly higher value in the documentation or even split into a recommended limit (e.g. 50) and a recommended absolute maximum (e.g. 76)? Hmm, the split wouldn't make sense, I think.

Markus
Previous: Ted Pavlic
Message 7 of 7 in “Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u."”
  1. 3/3 Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u."Ted Pavlic, Jan 13, 2009
  2. Shawn O. PearceJan 13, 2009
  3. Boyd Stephen Smith Jr.Jan 13, 2009
  4. Adeodato SimóJan 13, 2009
  5. Commit messagesTeemu Likonen, Jan 13, 2009
  6. Ted PavlicJan 14, 2009
  7. Markus HeidelbergJan 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.