From: Markus Heidelberg Date: Thu, 15 Jan 2009 22:56:00 GMT Subject: Re: [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u." Message-ID: <200901152356.00997.markus.heidelberg@web.de> In-Reply-To: <20090113201024.GA20129@chistera.yi.org> Adeodato Simó, 13.01.2009: > * Boyd Stephen Smith Jr. [Tue, 13 Jan 2009 14:03:11 -0600]: > > > On Tuesday 2009 January 13 10:45:18 Shawn O. Pearce wrote: > > >See [...] how the subject is a niceshort, one > > >line summary of the module impacted and the change? > > > My rule for this is absolutely no more than 80 characters. > > My rule for *all* of the commit message is "absolutely no more than 76 > characters". With more than 76, `git log` wraps in a 80-column terminal. What about the 50 character limit proposed in the documentation (git-commit, gittutorial, user-manual)? At the beginning I tried to fulfil this limit, but often it's not easy. So should it be adjusted to a slightly higher value in the documentation or even split into a recommended limit (e.g. 50) and a recommended absolute maximum (e.g. 76)? Hmm, the split wouldn't make sense, I think. Markus