Re: [PATCH 3/3] bash-completion: Added comments to remind about required arguments

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 15, 2009, 15:35 UTC
Message-ID: <20090115153543.GF10179@spearce.org>
In-Reply-To: <1231963342-24461-3-git-send-email-ted@tedpavlic.com>

ted@tedpavlic.com wrote:

Show 13 quoted lines

> From: Ted Pavlic <ted@tedpavlic.com>
> 
>   Adds a few simple comments above commands that take arguments. These
>   comments are meant to remind developers of potential problems that can
>   occur when the script is sourced on systems with "set -u." Any
>   function which "requires" arguments really ought to be called with
>   explicit arguments given.
> 
>   Also adds a #!bash to the top of bash completions so that editing
>   software can always identify that the file is of sh type.
> 
> Signed-off-by: Ted Pavlic <ted@tedpavlic.com>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>

Yup, this and also 2/3 look fine. But again, the message, it shouldn't be indented.

> ---
>  contrib/completion/git-completion.bash |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)

-- 
Shawn.