Re: [PATCH 1/3] bash-completion: Support running when set -u is enabled

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 15, 2009, 15:34 UTC
Message-ID: <20090115153402.GE10179@spearce.org>
In-Reply-To: <1231963342-24461-1-git-send-email-ted@tedpavlic.com>

ted@tedpavlic.com wrote:

Show 16 quoted lines

> From: Ted Pavlic <ted@tedpavlic.com>
> 
>   Under "set -u" semantics, it is an error to access undefined
>   variables. Some user environments may enable this setting in the
>   interactive shell.
> 
>   In any context where the completion functions access an undefined
>   variable, accessing a default empty string (aka "${1-}" instead of
>   "$1") is a reasonable way to code the function, as it silences
>   the undefined variable error while still supplying an empty string.
> 
>   In this patch, functions that should always take an argument still use
>   $1. Functions that have optional arguments use ${1-}.
> 
> Signed-off-by: Ted Pavlic <ted@tedpavlic.com>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>

Yup. This patch isn't as bad as everyone made it out to be. I think we should go ahead and include it.

But usually we don't indent the commit message like you did above; instead the message should be aligned on the left margin at column 0. git log will indent the message during display, hence any identation you add in the patch email just makes the message that much harder to read from git log.

> ---
>  contrib/completion/git-completion.bash |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)

-- 
Shawn.