git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Jan 12, 2009, 22:53 UTC
Message-ID
<200901122353.19408.robin.rosenberg.lists@dewire.com>
In-Reply-To
<20090112171045.GI10179@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote
Show 17 quoted lines
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts:
> > > I have attached a small fix for when a git config has /r lines in the file.
> > > I have to admit that I do not usually submit patches to the open source
> > > community and I am not very familiar with the process :-)  Please, please,
> > > let me know if I can do something different next time!
> > 
> > Back to the patch. I think we should only ignore \r (not /r, but could say CR in
> > a comment) before an LF. 
> 
> I disagree; ignoring CR anyplace in the file should be fine, unless
> it is within a double quoted value, in which case it should use
> the same rule that \n would use within the same region.
> 
> ' ', \n, \t all act the same with regards to being (mostly) ignored
> whitespace.  \r is no different.  Especially for anyone crazy enough
> to still be using a Mac style formatted file, with only CRs in it.

Those are copied from in to out in the repo config parser today. Why should ' \r' be treated differently? Just CR (FF, Ctrl-G etc) is garbage, but CRLF is a well established line terminator.

-- robin
Previous: Shawn O. Pearce
Message 3 of 3 in “Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]”
  1. Robin RosenbergJan 10, 2009
  2. Shawn O. PearceJan 12, 2009
  3. Robin RosenbergJan 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.