Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Jan 10, 2009, 20:34 UTC
Message-ID: <200901102134.05652.robin.rosenberg@dewire.com>
In-Reply-To: <142772020901071910ha95d53fo2454f8685908338c@mail.gmail.com>

torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts:

> I have attached a small fix for when a git config has /r lines in the file.
> I have to admit that I do not usually submit patches to the open source
> community and I am not very familiar with the process :-)  Please, please,
> let me know if I can do something different next time!

1) Inline the patch
No, need for such a large sign-off. It's good you declare that you have
understand the SOB-line.

You can add "extra" comments that should not go into the cBommit after the comment like this:

From:.. etc

"This" goes into the commit

Signed-off-by: Whom Ever  <whom.ever@example.com>
---

The three dashes ends the comment. Anything after it and the actual patch will be ignored by git am, but might be useful to the maintainer.

Back to the patch. I think we should only ignore \r (not /r, but could say CR in a comment) before an LF.

-- robin