Re: [PATCH] gitweb: suggest name for OPML view

From: Jakub Narebski <jnareb@gmail.com>
Date: Jan 10, 2009, 14:10 UTC
Message-ID: <200901101510.20918.jnareb@gmail.com>
In-Reply-To: <1230900570-25324-1-git-send-email-giuseppe.bilotta@gmail.com>

On Fri, 2 Jan 2009, Giuseppe Bilotta wrote:

> Suggest opml.xml as name for OPML view by providing the appropriate
> header, consistently with similar usage in project_index view.

It is not name for a view, but more of default filename when saving it. While it is good idea to have consistency, I guess that while 'project_index' view and other non-HTML views are meant to be downloaded and saved (snapshots, patches, patchsets), OPML view is meant to be used on-line, just like web feeds in RSS and Atom formats which are non-HTML too but do not have Content-Disposition header set.

But I do not use OPML. Anyone?

Show 27 quoted lines

> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
>  gitweb/gitweb.perl |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index b164001..995bc1a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -6122,7 +6122,11 @@ sub git_atom {
>  sub git_opml {
>  	my @list = git_get_projects_list();
>  
> -	print $cgi->header(-type => 'text/xml', -charset => 'utf-8');
> +	print $cgi->header(
> +		-type => 'text/xml',
> +		-charset => 'utf-8',
> +		-content_disposition => 'inline; filename="opml.xml"');
> +
>  	print <<XML;
>  <?xml version="1.0" encoding="utf-8"?>
>  <opml version="1.0">
> -- 
> 1.5.6.5
> 
>

-- 
Jakub Narebski
Poland