Re: [PATCH 3/3] pretty: support multiline subjects with format:

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Dec 28, 2008, 14:16 UTC
Message-ID: <200812281516.52080.markus.heidelberg@web.de>
In-Reply-To: <4956C47B.4020602@lsrfire.ath.cx>

René Scharfe, 28.12.2008:

Show 16 quoted lines

> Markus Heidelberg schrieb:
> >> For consistency and increased code reuse, change format: to do the
> >> same as the other options.
> > 
> > What's wrong with using the first line instead of the first paragraph
> > for the other pretty options and for cases where only a small subject
> > line is desired? A sentence would be broken into a small uncomplete part
> > for the subject for example. What else?
> 
> I'm inching towards the goal of being able to replicate all of the other
> --pretty flavours with format: (or tformat:) strings.
> 
> --pretty=oneline used to print only the first line, but was changed to
> the way it's now in 4234a761 more than a year ago.  In my mind,
> "subject" is defined by "what oneline is printing", so I think changing
> the format: placeholder %s to show the whole first paragraph is a bug fix.

Yes, now I think so, too. I had also noticed the unexpectedly different behaviour once.

> If you actually like the old behaviour then perhaps a new placeholder
> (%S ?) should be introduced instead?

I don't need it. I rather asked regarding the old behaviour for oneline and so, but reading that there are strong intentions for their behaviour, it's fine.

Markus