git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] pretty: support multiline subjects with format:

From
Nanako Shiraishi <nanako3@lavabit.com>
Date
Dec 28, 2008, 00:09 UTC
Message-ID
<20081228090909.6117@nanako3.lavabit.com>
In-Reply-To
<200812280024.59096.markus.heidelberg@web.de>
Quoting Markus Heidelberg <markus.heidelberg@web.de>:
Show 6 quoted lines
>> For consistency and increased code reuse, change format: to do the
>> same as the other options.
>
> What's wrong with using the first line instead of the first paragraph
> for the other pretty options and for cases where only a small subject
> line is desired?
There were too many issues. The mail archive tells us that there were considerable discussions and thoughts behind the current behavior:
	http://thread.gmane.org/gmane.comp.version-control.git/49694/focus=49922
	http://thread.gmane.org/gmane.comp.version-control.git/46341/focus=46818
	http://thread.gmane.org/gmane.comp.version-control.git/54020/focus=54132
	http://thread.gmane.org/gmane.comp.version-control.git/21949/focus=21987
The last message mentions a bug in "git rebase" that internally uses "git am" when replaying the changes. It was corrected later with:
	http://thread.gmane.org/gmane.linux.ports.sh.devel/3833/focus=79735
Reading the discussion in the messages in this thread will help understanding the issues, after understanding why "the first line" was problematic, as discussed in the other threads.
-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
Previous: Markus HeidelbergNext: Miklos Vajna
Message 5 of 15 in “pretty: factor out skip_empty_lines()”
  1. 1/3 pretty: factor out skip_empty_lines()René Scharfe, Dec 27, 2008
  2. 2/3 pretty: factor out format_subject()René Scharfe, Dec 27, 2008
  3. 3/3 pretty: support multiline subjects with format:René Scharfe, Dec 27, 2008
  4. Markus HeidelbergDec 27, 2008
  5. Nanako ShiraishiDec 28, 2008
  6. Miklos VajnaDec 28, 2008
  7. Markus HeidelbergDec 28, 2008
  8. René ScharfeDec 28, 2008
  9. Markus HeidelbergDec 28, 2008
  10. René ScharfeDec 29, 2008
  11. Junio C HamanoJan 4, 2009
  12. 4/3 shortlog: handle multi-line subjects like log --pretty=oneline et. al. doRené Scharfe, Jan 6, 2009
  13. Junio C HamanoJan 7, 2009
  14. Junio C HamanoDec 28, 2008
  15. Markus HeidelbergDec 28, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.