git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH][RESEND] guilt: add option guilt.diffstat

From
WFWu Fengguang <fengguang.wu@intel.com>
Date
Dec 18, 2008, 11:26 UTC
Message-ID
<20081218112643.GA15416@localhost>
In-Reply-To
<20081213131700.GA8649@localhost>

Introduce option guilt.diffstat so that we don't have to type "guilt refresh --diffstat" in its full form every time.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
Jeff: This patch is against the latest guilt v0.32-rc1.
 Documentation/guilt-refresh.txt |   10 ++++++++--
 guilt                           |    9 ++++++++-
 2 files changed, 16 insertions(+), 3 deletions(-)

--- guilt.orig/guilt +++ guilt/guilt

@@ -646,7 +646,7 @@ __refresh_patch()
 
 		[ ! -z "$4" ] && diffopts="-C -M --find-copies-harder"
 		
-		if [ ! -z "$5" ]; then
+		if [ -n "$5" -o $diffstat = "true" ]; then
 			(
 				echo "---"
 				git diff --stat $diffopts "$2"
@@ -737,10 +737,17 @@ guilt_hook()
 # used for: git apply -C <val>
 guilt_push_diff_context=1
 
+# default diffstat value: true or false
+DIFFSTAT_DEFAULT="false"
+
 #
 # Parse any part of .git/config that belongs to us
 #
 
+# generate diffstat?
+diffstat=`git config --bool guilt.diffstat`
+[ -z "$diffstat" ] && diffstat=$DIFFSTAT_DEFAULT
+
 #
 # The following gets run every time this file is source'd
 #
--- guilt.orig/Documentation/guilt-refresh.txt
+++ guilt/Documentation/guilt-refresh.txt
@@ -20,8 +20,14 @@ OPTIONS
 	format (e.g., rename and copy detection).
 
 --diffstat::
-	Include a diffstat output in the patch file. Useful for cases where
-	patches will be submitted with other tools.
+Include a diffstat output in the patch file. Useful for cases where
+patches will be submitted with other tools.
++
+If the command line option is omitted, the corresponding git-config
+option "guilt.diffstat" will be queried. So this would enable diffstat
+output by default:
+
+	git config --global guilt.diffstat true
 
 Author
 ------
Previous: Wu FengguangNext: Josef Jeff Sipek
Message 6 of 9 in “guilt: add option guilt.diffstat”
  1. guilt: add option guilt.diffstatWu Fengguang, Dec 13, 2008
  2. Josef Jeff SipekDec 13, 2008
  3. Boyd Stephen Smith Jr.Dec 13, 2008
  4. Josef Jeff SipekDec 13, 2008
  5. Wu FengguangDec 13, 2008
  6. [RESEND] guilt: add option guilt.diffstatWu Fengguang, Dec 18, 2008
  7. Josef Jeff SipekDec 18, 2008
  8. Wu FengguangDec 19, 2008
  9. Josef Jeff SipekDec 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.