Re: [PATCH] guilt: add option guilt.diffstat
On Sat, Dec 13, 2008 at 12:18:50AM -0600, Boyd Stephen Smith Jr. wrote:
Show 9 quoted lines
> On Friday 2008 December 12 22:43:57 Josef Jeff Sipek wrote:
> >> + if [ -n "$5" -o "x$diffstat" = "x1" ]; then
> >
> >Why the 'x' thing? I've seen it is some scripts before, but I can't think of
> >a reason to use it if the variable is surrounded in quotation marks.
>
> '[' or test see the arguments after they are unquoted (normally). So,
> if "$diffstat" is "-n" it might try and do the -n test, rather than the =
> test.
Oh. I haven't even thought of that posibility!
> It could be re-written as "1" == "${diffstat}" instead to avoid the x, but
> it's not a big deal (to me). That also looks backwards to a lot of people.Including me.
Thanks for the info.
Josef 'Jeff' Sipek.
--
Penguin : Linux version 2.6.25.4 on an i386 machine (6135.73 BogoMips).