Re: [PATCH 2/2] diff: respect textconv in rewrite diffs

From: Jeff King <peff@peff.net>
Date: Dec 10, 2008, 09:02 UTC
Message-ID: <20081210090221.GA11367@coredump.intra.peff.net>
In-Reply-To: <7v3agw2zu5.fsf@gitster.siamese.dyndns.org>

On Wed, Dec 10, 2008 at 12:34:26AM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> > +cat >dump <<'EOF'
> > +#!/bin/sh
> > +perl -e '$/ = undef; $_ = <>; s/./ord($&)/ge; print $_' < "$1"
> > +EOF
> 
> I'll squash in a change to make this part use $SHELL_PATH for
> consistency.  Thanks.

It was cut-and-paste from t4030, so if we care, it might be worth changing there, too (and naming it "dump" instead of "hexdump", because it actually dumps in decimal :) ).

But more importantly, the fixup you just pushed seems to have an extra ">dump":

Show 7 quoted lines

> +{
> +       echo "#!$SHELL_PATH"
> +       cat >dump <<'EOF'
> +perl -e '$/ = undef; $_ = <>; s/./ord($&)/ge; print $_' < "$1"
> +EOF
> +} >dump
> +chmod +x dump

-Peff