git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git Notes - Track rebase/etc + reverse-lookup for bugs ideas

From
Jeff King <peff@peff.net>
Date
Nov 11, 2008, 00:31 UTC
Message-ID
<20081111003136.GA26481@coredump.intra.peff.net>
In-Reply-To
<74EBEC20-FC39-444E-8B96-31E5B36894B8@gmail.com>
On Mon, Nov 10, 2008 at 03:26:52PM -0500, Thomas Harning wrote:
> What I intended is that if notes are attached to 'A',  A` (after a  
> rebase) will have the exact same note.

I think that may have been brought up at the GitTogether. It would be very easy, when rebasing A to A', to copy any notes for A to A' (retroactively applying notes for A' to A (or vice versa) is much harder, since we don't maintain any mapping between the two).

_But_ that is not necessarily a good idea in all cases, because your notes may say certain things about A like "I tested this on system X". But you _haven't_ tested A', and it might not pass your test. Leaving aside editing the commits with "rebase -i", there might just be a bad interaction with the commit you rebased onto.

So I think it would probably make sense to add a "--copy-notes" option to rebase for those times when the user knows it makes sense, but doing so by default is probably a mistake.

-Peff
Previous: Thomas Harning
Message 10 of 10 in “Git Notes - Track rebase/etc + reverse-lookup for bugs ideas”
  1. Thomas HarningNov 10, 2008
  2. Jeff KingNov 10, 2008
  3. Johannes SchindelinNov 10, 2008
  4. Jeff KingNov 10, 2008
  5. Johan HerlandNov 10, 2008
  6. Miklos VajnaNov 10, 2008
  7. Johan HerlandNov 10, 2008
  8. Johannes SchindelinNov 10, 2008
  9. Thomas HarningNov 10, 2008
  10. Jeff KingNov 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.